netdev - Re: [PATCH net v3] openvswitch: Fix pop_vlan action for double tagged frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Dec 2017 21:17:15 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Eric Garver <e@...g.me>
Cc:     netdev@...r.kernel.org, ovs-dev@...nvswitch.org
Subject: Re: [PATCH net v3] openvswitch: Fix pop_vlan action for double
 tagged frames

On Wed, 20 Dec 2017 15:09:22 -0500, Eric Garver wrote:
> skb_vlan_pop() expects skb->protocol to be a valid TPID for double
> tagged frames. So set skb->protocol to the TPID and let skb_vlan_pop()
> shift the true ethertype into position for us.
> 
> Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets")
> Signed-off-by: Eric Garver <e@...g.me>

Thanks!

Reviewed-by: Jiri Benc <jbenc@...hat.com>