netdev - [PATCH RFC 16/18] r8168: use phy_read/write in rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Dec 2017 21:50:49 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        Chun-Hao Lin <hau@...ltek.com>
Cc:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [PATCH RFC 16/18] r8168: use phy_read/write in rtl_readphy/writephy
 helpers

Instead of accessing mdio_ops directly use phy_read/write in these
helpers.

Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
---
 drivers/net/ethernet/realtek/r8168.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/realtek/r8168.c b/drivers/net/ethernet/realtek/r8168.c
index 91191d178..64c87509d 100644
--- a/drivers/net/ethernet/realtek/r8168.c
+++ b/drivers/net/ethernet/realtek/r8168.c
@@ -1167,12 +1167,12 @@ static int r8168dp_2_mdio_read(struct rtl8168_private *tp, int reg)
 
 static void rtl_writephy(struct rtl8168_private *tp, int location, u32 val)
 {
-	tp->mdio_ops.write(tp, location, val);
+	phy_write(tp->dev->phydev, location, val);
 }
 
 static int rtl_readphy(struct rtl8168_private *tp, int location)
 {
-	return tp->mdio_ops.read(tp, location);
+	return phy_read(tp->dev->phydev, location);
 }
 
 static void rtl_patchphy(struct rtl8168_private *tp, int reg_addr, int value)
-- 
2.15.1