netdev - Re: [PATCHv2 net] l2tp: fix missing print session offset info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Dec 2017 12:24:01 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, James Chapman <jchapman@...alix.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCHv2 net] l2tp: fix missing print session offset info

> Fixes: 309795f4bec ("l2tp: Add netlink control API for L2TP")
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  net/l2tp/l2tp_netlink.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c
> index a1f24fb..36378b4 100644
> --- a/net/l2tp/l2tp_netlink.c
> +++ b/net/l2tp/l2tp_netlink.c
> @@ -761,6 +761,8 @@ static int l2tp_nl_session_send(struct sk_buff *skb, u32 portid, u32 seq, int fl
>
>         if ((session->ifname[0] &&
>              nla_put_string(skb, L2TP_ATTR_IFNAME, session->ifname)) ||
> +           (session->offset &&
> +            nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset)) ||
>             (session->cookie_len &&
>              nla_put(skb, L2TP_ATTR_COOKIE, session->cookie_len,
>                      &session->cookie[0])) ||
> --
> 2.5.5
>

Hi David,

please hold on a while with this patch, I will send it in a patchset
that addresses some offset related stuff.
Regards,

Lorenzo