lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Dec 2017 13:01:30 -0500 (EST) From: David Miller <davem@...emloft.net> To: jon.maloy@...csson.com Cc: netdev@...r.kernel.org, mohan.krishna.ghanta.krishnamurthy@...csson.com, tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au, canh.d.luu@...tech.com.au, ying.xue@...driver.com, tipc-discussion@...ts.sourceforge.net Subject: Re: [net 1/1] tipc: base group replicast ack counter on number of actual receivers From: Jon Maloy <jon.maloy@...csson.com> Date: Thu, 21 Dec 2017 13:07:11 +0100 > In commit 2f487712b893 ("tipc: guarantee that group broadcast doesn't > bypass group unicast") we introduced a mechanism that requires the first > (replicated) broadcast sent after a unicast to be acknowledged by all > receivers before permitting sending of the next (true) broadcast. > > The counter for keeping track of the number of acknowledges to expect > is based on the tipc_group::member_cnt variable. But this misses that > some of the known members may not be ready for reception, and will never > acknowledge the message, either because they haven't fully joined the > group or because they are leaving the group. Such members are identified > by not fulfilling the condition tested for in the function > tipc_group_is_enabled(). > > We now set the counter for the actual number of acks to receive at the > moment the message is sent, by just counting the number of recipients > satisfying the tipc_group_is_enabled() test. > > Signed-off-by: Jon Maloy <jon.maloy@...csson.com> Applied, thanks Jon.
Powered by blists - more mailing lists