netdev - Re: [PATCH net-next 0/4] zerocopy refinements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Dec 2017 16:45:51 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net-next 0/4] zerocopy refinements

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Fri, 22 Dec 2017 19:00:16 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> 1/4 is a small optimization follow-up to the earlier fix to skb_segment:
>     check skb state once per skb, instead of once per frag.
> 2/4 makes behavior more consistent between standard and zerocopy send:
>     set the PSH bit when hitting MAX_SKB_FRAGS. This helps GRO.
> 3/4 resolves a surprising inconsistency in notification:
>     because small packets were not stored in frags, they would not set
>     the copied error code over loopback. This change also optimizes
>     the path by removing copying and making tso_fragment cheaper.
> 4/4 follows-up to 3/4 by no longer allocated now unused memory.
>     this was actually already in RFC patches, but dropped as I pared
>     down the patch set during revisions.

Looks good, series applied, thanks.