lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Dec 2017 06:24:57 +0000 From: "Shaikh, Shahed" <Shahed.Shaikh@...ium.com> To: "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>, "Elior, Ariel" <Ariel.Elior@...ium.com>, Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@...ium.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "gpiccoli@...tonmail.ch" <gpiccoli@...tonmail.ch> Subject: RE: [PATCH net] bnx2x: Improve reliability in case of nested PCI errors > -----Original Message----- > From: Guilherme G. Piccoli [mailto:gpiccoli@...ux.vnet.ibm.com] > Sent: Friday, December 22, 2017 8:32 PM > To: Elior, Ariel <Ariel.Elior@...ium.com>; Dept-Eng Everest Linux L2 <Dept- > EngEverestLinuxL2@...ium.com> > Cc: netdev@...r.kernel.org; gpiccoli@...ux.vnet.ibm.com; > gpiccoli@...tonmail.ch > Subject: [PATCH net] bnx2x: Improve reliability in case of nested PCI errors > > While in recovery process of PCI error (called EEH on PowerPC arch), another > PCI transaction could be corrupted causing a situation of nested PCI errors. Also, > this scenario could be reproduced with error injection mechanisms (for debug > purposes). > > We observe that in case of nested PCI errors, bnx2x might attempt to initialize > its shmem and cause a kernel crash due to bad addresses read from MCP. > Multiple different stack traces were observed depending on the point the second > PCI error happens. > > This patch avoids the crashes by: > > * failing PCI recovery in case of nested errors (since multiple PCI errors in a row > are not expected to lead to a functional adapter anyway), and by, > > * preventing access to adapter FW when MCP is failed (we mark it as failed > when shmem cannot get initialized properly). > > Reported-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com> > Signed-off-by: Guilherme G. Piccoli <gpiccoli@...ux.vnet.ibm.com> Acked-by: Shahed Shaikh <Shahed.Shaikh@...ium.com> Thanks, Shahed
Powered by blists - more mailing lists