lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Dec 2017 11:05:19 +0100 From: Antoine Tenart <antoine.tenart@...e-electrons.com> To: Andrew Lunn <andrew@...n.ch> Cc: Russell King - ARM Linux <linux@...linux.org.uk>, Antoine Tenart <antoine.tenart@...e-electrons.com>, davem@...emloft.net, kishon@...com, jason@...edaemon.net, sebastian.hesselbarth@...il.com, gregory.clement@...e-electrons.com, mw@...ihalf.com, stefanc@...vell.com, ymarkman@...vell.com, thomas.petazzoni@...e-electrons.com, miquel.raynal@...e-electrons.com, nadavh@...vell.com, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface Hi Andrew, On Thu, Dec 28, 2017 at 08:46:23AM +0100, Andrew Lunn wrote: > On Wed, Dec 27, 2017 at 10:24:01PM +0000, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > > > > > +&cps_eth2 { > > > + /* CPS Lane 5 */ > > > + status = "okay"; > > > + phy-mode = "2500base-x"; > > > + /* Generic PHY, providing serdes lanes */ > > > + phys = <&cps_comphy5 2>; > > > +}; > > > + > > > > This is wrong. This lane is connected to a SFP cage which can support > > more than just 2500base-X. Tying it in this way to 2500base-X means > > that this port does not support conenctions at 1000base-X, despite > > that's one of the most popular and more standardised speeds. > > > > I agree with Russell here. SFP modules are hot pluggable, and support > a range of interface modes. You need to query what the SFP module is > in order to know how to configure the SERDES interface. The phylink > infrastructure does that for you. Sure, I understand. We'll be able to support such interfaces only when the phylink PPv2 support lands in. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Powered by blists - more mailing lists