netdev - [PATCH] net: hns: Delete an error message for a failed memory allocation in hns_rcb_common_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 1 Jan 2018 19:19:07 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        lipeng <lipeng321@...wei.com>,
        Matthias Brugger <mbrugger@...e.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        Timmy Li <lixiaoping3@...wei.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] net: hns: Delete an error message for a failed memory
 allocation in hns_rcb_common_get_cfg()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 1 Jan 2018 19:11:46 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
index 6f3570cfb501..cd74f0598dde 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c
@@ -767,10 +767,9 @@ int hns_rcb_common_get_cfg(struct dsaf_device *dsaf_dev,
 	rcb_common =
 		devm_kzalloc(dsaf_dev->dev, sizeof(*rcb_common) +
 			ring_num * sizeof(struct ring_pair_cb), GFP_KERNEL);
-	if (!rcb_common) {
-		dev_err(dsaf_dev->dev, "rcb common devm_kzalloc fail!\n");
+	if (!rcb_common)
 		return -ENOMEM;
-	}
+
 	rcb_common->comm_index = comm_index;
 	rcb_common->ring_num = ring_num;
 	rcb_common->dsaf_dev = dsaf_dev;
-- 
2.15.1