netdev - Re: [PATCH net 0/2] IB/ipoib: ip link support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Jan 2018 11:15:52 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Erez Shitrit <erezsh@....mellanox.co.il>
Cc:     Denis Drozdov <denisd@...lanox.com>,
        Erez Shitrit <erezsh@...lanox.com>,
        David Miller <davem@...emloft.net>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net 0/2] IB/ipoib: ip link support

On Tue, Jan 2, 2018 at 10:44 AM, Erez Shitrit <erezsh@....mellanox.co.il> wrote:
> On Tue, Jan 2, 2018 at 9:29 AM, Or Gerlitz <gerlitz.or@...il.com> wrote:
>> On Sun, Dec 31, 2017 at 2:28 PM, Or Gerlitz <gerlitz.or@...il.com> wrote:
>>> On Sun, Dec 31, 2017 at 1:16 PM, Denis Drozdov <denisd@...lanox.com> wrote:
>>>> IP link was broken due to the changes in IPoIB for the rdma_netdev
>>>> support after commit cd565b4b51e5
>>>> ("IB/IPoIB: Support acceleration options callbacks").
>>>
>>> you are approaching stable kernels, right? lets make sure dave is okay
>>> to pick the net (touching dev.c etc) patch to stable even if the
>>> offending patch didn't change anything there.
>>
>> Erez, Denis
>>
>> The offending commit went in 4.12-rc1, so the fix should be getting
>> a while back. RU sure you need the net/core patch to fix that up or
>> we can come up with ipoib only patch?
>
> The preferred approach was to have 2 patches one for ipoib and one for core/net.
> So, we can't with patch to ipoib only.

going with your approach, you must sure that the 1st patch is also
backportable all the way back to 4.12

Or.

> Denis, the author of the patches is on new-year vacation, he will
> close all the gaps as soon as he will be back.