netdev - Re: [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 05 Jan 2018 03:53:46 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Natale Patriciello <natale.patriciello@...il.com>,
        netdev@...r.kernel.org
Cc:     Carlo Augusto Grazia <carloaugusto.grazia@...more.it>
Subject: Re: [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ

On Fri, 2018-01-05 at 12:32 +0100, Natale Patriciello wrote:
> The original TSQ algorithm limits the number of packets in qdisc/devices to
> two packets / or ~1 ms. With this commit, two sysctl knobs are added to
> allow tuning the number of packets or the ms value.
> 
> Signed-off-by: Natale Patriciello <natale.patriciello@...il.com>
> Cc: Carlo Augusto Grazia <carloaugusto.grazia@...more.it>
> Tested-by: Carlo Augusto Grazia <carloaugusto.grazia@...more.it>
> ---

NACK

You provide dubious reasons, and no real tests done on various
hardwares.

We do not want sysctls that wont solve the issue you try to address.

Your patch series comes too late.

A linux host can have one 10Gbit NIC and a wifi adapter, they require
different tunings.

This is why we added sk_pacing_shift_update().

If this needs refinement, lets talk.