netdev - Re: [PATCH net-next] tcp: Split BUG_ON() in tcp_tso_should

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 08 Jan 2018 14:12:41 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sbrivio@...hat.com
Cc:     eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: Split BUG_ON() in tcp_tso_should_defer()
 into two assertions

From: Stefano Brivio <sbrivio@...hat.com>
Date: Fri,  5 Jan 2018 00:38:05 +0100

> The two conditions triggering BUG_ON() are somewhat unrelated:
> the tcp_skb_pcount() check is meant to catch TSO flaws, the
> second one checks sanity of congestion window bookkeeping.
> 
> Split them into two separate BUG_ON() assertions on two lines,
> so that we know which one actually triggers, when they do.
> 
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>

Applied.