netdev - [nf-next:master 54/54] net//netfilter/nf_flow_table.c:196:6: error: void value not ignored as it ought to be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 8 Jan 2018 23:40:45 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     kbuild-all@...org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: [nf-next:master 54/54] net//netfilter/nf_flow_table.c:196:6: error:
 void value not ignored as it ought to be

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
head:   7844629488fd1489d19a08ce25a51e03e69834a7
commit: 7844629488fd1489d19a08ce25a51e03e69834a7 [54/54] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 7844629488fd1489d19a08ce25a51e03e69834a7
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   net//netfilter/nf_flow_table.c: In function 'nf_flow_table_iterate':
>> net//netfilter/nf_flow_table.c:196:6: error: void value not ignored as it ought to be
     err = rhashtable_walk_start(&hti);
         ^
   net//netfilter/nf_flow_table.c: In function 'nf_flow_offload_work_gc':
   net//netfilter/nf_flow_table.c:244:6: error: void value not ignored as it ought to be
     err = rhashtable_walk_start(&hti);
         ^

vim +196 net//netfilter/nf_flow_table.c

43aa1d78 Pablo Neira Ayuso 2018-01-07  185  
43aa1d78 Pablo Neira Ayuso 2018-01-07  186  int nf_flow_table_iterate(struct nf_flowtable *flow_table,
43aa1d78 Pablo Neira Ayuso 2018-01-07  187  			  void (*iter)(struct flow_offload *flow, void *data),
43aa1d78 Pablo Neira Ayuso 2018-01-07  188  			  void *data)
43aa1d78 Pablo Neira Ayuso 2018-01-07  189  {
43aa1d78 Pablo Neira Ayuso 2018-01-07  190  	struct flow_offload_tuple_rhash *tuplehash;
43aa1d78 Pablo Neira Ayuso 2018-01-07  191  	struct rhashtable_iter hti;
43aa1d78 Pablo Neira Ayuso 2018-01-07  192  	struct flow_offload *flow;
43aa1d78 Pablo Neira Ayuso 2018-01-07  193  	int err;
43aa1d78 Pablo Neira Ayuso 2018-01-07  194  
43aa1d78 Pablo Neira Ayuso 2018-01-07  195  	rhashtable_walk_init(&flow_table->rhashtable, &hti, GFP_KERNEL);
43aa1d78 Pablo Neira Ayuso 2018-01-07 @196  	err = rhashtable_walk_start(&hti);
43aa1d78 Pablo Neira Ayuso 2018-01-07  197  	if (err && err != -EAGAIN)
43aa1d78 Pablo Neira Ayuso 2018-01-07  198  		goto out;
43aa1d78 Pablo Neira Ayuso 2018-01-07  199  
43aa1d78 Pablo Neira Ayuso 2018-01-07  200  	while ((tuplehash = rhashtable_walk_next(&hti))) {
43aa1d78 Pablo Neira Ayuso 2018-01-07  201  		if (IS_ERR(tuplehash)) {
43aa1d78 Pablo Neira Ayuso 2018-01-07  202  			err = PTR_ERR(tuplehash);
43aa1d78 Pablo Neira Ayuso 2018-01-07  203  			if (err != -EAGAIN)
43aa1d78 Pablo Neira Ayuso 2018-01-07  204  				goto out;
43aa1d78 Pablo Neira Ayuso 2018-01-07  205  
43aa1d78 Pablo Neira Ayuso 2018-01-07  206  			continue;
43aa1d78 Pablo Neira Ayuso 2018-01-07  207  		}
43aa1d78 Pablo Neira Ayuso 2018-01-07  208  		if (tuplehash->tuple.dir)
43aa1d78 Pablo Neira Ayuso 2018-01-07  209  			continue;
43aa1d78 Pablo Neira Ayuso 2018-01-07  210  
43aa1d78 Pablo Neira Ayuso 2018-01-07  211  		flow = container_of(tuplehash, struct flow_offload, tuplehash[0]);
43aa1d78 Pablo Neira Ayuso 2018-01-07  212  
43aa1d78 Pablo Neira Ayuso 2018-01-07  213  		iter(flow, data);
43aa1d78 Pablo Neira Ayuso 2018-01-07  214  	}
43aa1d78 Pablo Neira Ayuso 2018-01-07  215  out:
43aa1d78 Pablo Neira Ayuso 2018-01-07  216  	rhashtable_walk_stop(&hti);
43aa1d78 Pablo Neira Ayuso 2018-01-07  217  	rhashtable_walk_exit(&hti);
43aa1d78 Pablo Neira Ayuso 2018-01-07  218  
43aa1d78 Pablo Neira Ayuso 2018-01-07  219  	return err;
43aa1d78 Pablo Neira Ayuso 2018-01-07  220  }
43aa1d78 Pablo Neira Ayuso 2018-01-07  221  EXPORT_SYMBOL_GPL(nf_flow_table_iterate);
43aa1d78 Pablo Neira Ayuso 2018-01-07  222  

:::::: The code at line 196 was first introduced by commit
:::::: 43aa1d78410180a6354231a04bfb643a634bcfbd netfilter: add generic flow table infrastructure

:::::: TO: Pablo Neira Ayuso <pablo@...filter.org>
:::::: CC: Pablo Neira Ayuso <pablo@...filter.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (49872 bytes)