netdev - Re: [PATCH net] ipv6: fix possible mem leaks in ipv6_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 09:00:44 -0500
From:   Mike Maloney <maloneykernel@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Vladislav Yasevich <vyasevic@...hat.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Mike Maloney <maloney@...gle.com>
Subject: Re: [PATCH net] ipv6: fix possible mem leaks in ipv6_make_skb()

Acked-by:  Mike Maloney <maloney@...gle.com>

Thanks Eric!

On Wed, Jan 10, 2018 at 6:45 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> ip6_setup_cork() might return an error, while memory allocations have
> been done and must be rolled back.
>
> Fixes: 6422398c2ab0 ("ipv6: introduce ipv6_make_skb")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Vlad Yasevich <vyasevich@...il.com>
> Reported-by: Mike Maloney <maloney@...gle.com>
> ---
>  net/ipv6/ip6_output.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index f7dd51c4231415fd1321fd431194d896ea2d1689..688ba5f7516b37c87b879036dce781bdcfa01739 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -1735,9 +1735,10 @@ struct sk_buff *ip6_make_skb(struct sock *sk,
>         cork.base.opt = NULL;
>         v6_cork.opt = NULL;
>         err = ip6_setup_cork(sk, &cork, &v6_cork, ipc6, rt, fl6);
> -       if (err)
> +       if (err) {
> +               ip6_cork_release(&cork, &v6_cork);
>                 return ERR_PTR(err);
> -
> +       }
>         if (ipc6->dontfrag < 0)
>                 ipc6->dontfrag = inet6_sk(sk)->dontfrag;
>