netdev - RE: [PATCH net-next 3/3] r8169: improve runtime pm in general and suspend unused ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 04:01:12 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        nic_swsd <nic_swsd@...ltek.com>,
        David Miller <davem@...emloft.net>
CC:     Francois Romieu <romieu@...zoreil.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 3/3] r8169: improve runtime pm in general and suspend unused ports

Heiner Kallweit [mailto:hkallweit1@...il.com]
> Sent: Tuesday, January 09, 2018 4:39 AM
[...]
> - Change rtl8169_runtime_suspend to power down the chip if the
>   interface is down.

The original driver has done it. I don't think you have to do it again in rtl8169_runtime_suspend().

[...]
> -	if (!tp->TxDescArray)
> +	if (!tp->TxDescArray) {
> +		rtl_pll_power_down(tp);
>  		return 0;
> +	}

It is unnecessary.

Best Regards,
Hayes