netdev - Re: [PATCH net] sctp: removed unused var from sctp_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Jan 2018 12:50:34 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>,
        Vlad Yasevich <vyasevich@...il.com>
Subject: Re: [PATCH net] sctp: removed unused var from sctp_make_auth

On Fri, Jan 12, 2018 at 12:22 AM, Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> ---
>  net/sctp/sm_make_chunk.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 9bf575f2e8ed0888e0219a872e84018ada5064e0..f08531de5682256064ce35e3d44200caa71c3db8 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -1273,7 +1273,6 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
>         struct sctp_authhdr auth_hdr;
>         struct sctp_hmac *hmac_desc;
>         struct sctp_chunk *retval;
> -       __u8 *hmac;
>
>         /* Get the first hmac that the peer told us to use */
>         hmac_desc = sctp_auth_asoc_get_hmac(asoc);
> @@ -1292,7 +1291,7 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
>         retval->subh.auth_hdr = sctp_addto_chunk(retval, sizeof(auth_hdr),
>                                                  &auth_hdr);
>
> -       hmac = skb_put_zero(retval->skb, hmac_desc->hmac_len);
> +       skb_put_zero(retval->skb, hmac_desc->hmac_len);
>
>         /* Adjust the chunk header to include the empty MAC */
>         retval->chunk_hdr->length =
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reviewed-by: Xin Long <lucien.xin@...il.com>