netdev - DPAA Ethernet traffice troubles with Linux kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Jan 2018 20:03:45 +0100
From:   Christian Zigotzky <chzigotzky@...osoft.de>
To:     Joakim Tjernlund <Joakim.Tjernlund@...inera.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "madalin.bucur@....com" <madalin.bucur@....com>,
        "madskateman@...il.com" <madskateman@...il.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: DPAA Ethernet traffice troubles with Linux kernel

Hi All,

I compiled the RC8 of kernel 4.15 with Joakim's patch for the AmigaOne 
X5000 today. Many thanks to Joakim for the mdio patch.

Please test it on your X5000.

Thanks,
Christian


On 15 January 2018 at 5:59PM, Joakim Tjernlund wrote:
>>
>> Hi,
>>
>> Please use text logs instead of pictures next time, it's easier to read.
>> The errors you see are related to missing MAC addresses for the unused
>> interfaces, you can ignore these are they are not relevant for the issue
>> you encounter. Normally the unused interfaces should have status disabled
>> in the device tree but there is not a big deal if they fail like that.
>> As I've advised Jamie on the other thread, please try to connect the device
>> back 2 back to a known good machine and determine what is broken - Rx/Tx?
>> Is there another software version that does work on these machines?
> Hi, just saw this and thought of a small patch I just wrote for mdio bus, o idea
> if it is relevant but here goes:
>
>  From fe0b98d54a79779482700676331b4d10a0f3cada Mon Sep 17 00:00:00 2001
> From: Joakim Tjernlund <joakim.tjernlund@...inera.com>
> Date: Sun, 14 Jan 2018 21:27:20 +0100
> Subject: [PATCH] of_mdiobus_register: Continue after error
>
> of_mdiobus_register unregister itself if one phy fails to register
> which is bad for system having all its PHYs on the same MDIO bus.
> Just log the error and continue with the remaining PHYs instead.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@...inera.com>
> ---
>   drivers/of/of_mdio.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 98258583abb0..76ff28a41dad 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -229,7 +229,8 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
>   		else
>   			rc = of_mdiobus_register_device(mdio, child, addr);
>   		if (rc)
> -			goto unregister;
> +			pr_warn(FW_WARN
> +				"%pOF: Failed to register MDIO device.\n", child);
>   	}
>   
>   	if (!scanphys)
> @@ -253,7 +254,8 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
>   			if (of_mdiobus_child_is_phy(child)) {
>   				rc = of_mdiobus_register_phy(mdio, child, addr);
>   				if (rc)
> -					goto unregister;
> +					pr_warn(FW_WARN
> +						"%pOF: Failed to register MDIO PHY.\n", child);
>   			}
>   		}
>   	}