netdev - Re: [PATCH net-next] mlxsw: spectrum: Make function mlxsw_sp_kvdl_part

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Jan 2018 15:18:42 +0200
From:   Arkadi Sharshevsky <arkadis@...lanox.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] mlxsw: spectrum: Make function
 mlxsw_sp_kvdl_part_occ() static



On 01/17/2018 05:27 AM, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:289:5: warning:
>  symbol 'mlxsw_sp_kvdl_part_occ' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Acked-by: Arkadi Sharshevsky <arkadis@...lanox.com>

> ---
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> index cfacc17..55f9d2d 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> @@ -286,7 +286,7 @@ static void mlxsw_sp_kvdl_parts_fini(struct mlxsw_sp *mlxsw_sp)
>  		mlxsw_sp_kvdl_part_fini(mlxsw_sp, i);
>  }
>  
> -u64 mlxsw_sp_kvdl_part_occ(struct mlxsw_sp_kvdl_part *part)
> +static u64 mlxsw_sp_kvdl_part_occ(struct mlxsw_sp_kvdl_part *part)
>  {
>  	unsigned int nr_entries;
>  	int bit = -1;
>