netdev - Re: [PATCH 1/3 net] ibmvnic: Modify buffer size on failover

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 20:18:31 +0800
From:   kbuild test robot <lkp@...el.com>
To:     John Allen <jallen@...ux.vnet.ibm.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>,
        Nathan Fontenot <nfont@...ux.vnet.ibm.com>,
        desnesn@...ux.vnet.ibm.com
Subject: Re: [PATCH 1/3 net] ibmvnic: Modify buffer size on failover

Hi John,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/John-Allen/ibmvnic-Modify-buffer-size-on-failover/20180118-190528
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   drivers/net//ethernet/ibm/ibmvnic.c: In function 'reset_rx_pools':
>> drivers/net//ethernet/ibm/ibmvnic.c:414:2: error: 'size_array' undeclared (first use in this function); did you mean 'sem_array'?
     size_array = (u64 *)((u8 *)(adapter->login_rsp_buf) +
     ^~~~~~~~~~
     sem_array
   drivers/net//ethernet/ibm/ibmvnic.c:414:2: note: each undeclared identifier is reported only once for each function it appears in

vim +414 drivers/net//ethernet/ibm/ibmvnic.c

   407	
   408	static int reset_rx_pools(struct ibmvnic_adapter *adapter)
   409	{
   410		struct ibmvnic_rx_pool *rx_pool;
   411		int rx_scrqs;
   412		int i, j, rc;
   413	
 > 414		size_array = (u64 *)((u8 *)(adapter->login_rsp_buf) +
   415			be32_to_cpu(adapter->login_rsp_buf->off_rxadd_buff_size));
   416	
   417		rx_scrqs = be32_to_cpu(adapter->login_rsp_buf->num_rxadd_subcrqs);
   418		for (i = 0; i < rx_scrqs; i++) {
   419			rx_pool = &adapter->rx_pool[i];
   420	
   421			netdev_dbg(adapter->netdev, "Re-setting rx_pool[%d]\n", i);
   422	
   423			if (rx_pool->buff_size != be64_to_cpu(size_array[i])) {
   424				rx_pool->buff_size = be64_to_cpu(size_array[i]);
   425				rc = alloc_long_term_buff(adapter,
   426							  &rx_pool->long_term_buff,
   427							  rx_pool->size *
   428							  rx_pool->buff_size);
   429			} else {
   430				rc = reset_long_term_buff(adapter,
   431							  &rx_pool->long_term_buff);
   432			}
   433			if (rc)
   434				return rc;
   435	
   436			for (j = 0; j < rx_pool->size; j++)
   437				rx_pool->free_map[j] = j;
   438	
   439			memset(rx_pool->rx_buff, 0,
   440			       rx_pool->size * sizeof(struct ibmvnic_rx_buff));
   441	
   442			atomic_set(&rx_pool->available, 0);
   443			rx_pool->next_alloc = 0;
   444			rx_pool->next_free = 0;
   445			rx_pool->active = 1;
   446		}
   447	
   448		return 0;
   449	}
   450	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (56135 bytes)