netdev - Re: [PATCH] can: m_can: mark runtime-PM handlers as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 14:16:37 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Arnd Bergmann <arnd@...db.de>,
        Wolfgang Grandegger <wg@...ndegger.com>
Cc:     Mario Huettel <mario.huettel@....net>,
        Faiz Abbas <faiz_abbas@...com>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        Quentin Schulz <quentin.schulz@...e-electrons.com>,
        Franklin S Cooper Jr <fcooper@...com>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused

On 01/18/2018 02:04 PM, Arnd Bergmann wrote:
> Building without CONFIG_PM results in a harmless warning:
> 
> drivers/net/can/m_can/m_can.c:1763:12: error: 'm_can_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/net/can/m_can/m_can.c:1752:12: error: 'm_can_runtime_suspend' defined but not used [-Werror=unused-function]
> 
> Marking the functions as __maybe_unused lets the compiler
> silently drop them instead.
> 
> Fixes: cdf8259d6573 ("can: m_can: Add PM Support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Tnx - applied.

However all archs using this driver have mandatory PM support and the
driver depends on it.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)