netdev - Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jan 2018 00:57:24 +0800
From:   Kai Heng Feng <kai.heng.feng@...onical.com>
To:     David Miller <davem@...emloft.net>
Cc:     Hayes Wang <hayeswang@...ltek.com>, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, mario.limonciello@...l.com,
        nic_swsd@...ltek.com
Subject: Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock



> On 18 Jan 2018, at 10:50 PM, David Miller <davem@...emloft.net> wrote:
> 
> From: Hayes Wang <hayeswang@...ltek.com>
> Date: Thu, 18 Jan 2018 03:04:08 +0000
> 
>> [...]
>>>> r8153 on Dell TB15/16 dock corrupts rx packets.
>>>> 
>>>> This change is suggested by Realtek. They guess that the XHCI
>>>> controller doesn't have enough buffer, and their guesswork is correct,
>>>> once the RX aggregation gets disabled, the issue is gone.
>>>> 
>>>> ASMedia is currently working on a real sulotion for this issue.
>>>> 
>>>> Dell and ODM confirm the bcdDevice and iSerialNumber is unique for TB16.
>>>> 
>>>> Note that TB15 has different bcdDevice and iSerialNumber, which are
>>>> not unique values. If you still have TB15, please contact Dell to
>>>> replace it with TB16.
>> 
>> Excuse me. I don't understand why this patch is for specific USB nic rather than xHCI.
>> It seems to make the specific USB nic working and the other ones keeping error.
> 
> Well, are we sure that the device being in the TB16 dock doesn't
> contribute to the issue as well?

This is what vendors concluded for now. The very same NIC on WD15 doesn’t
have the issue.

> 
> If the problem only shows up with XHCI and this dock, then this patch
> was the appropriate way to deal with the problem for now.