lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Jan 2018 12:45:14 -0800 From: William Tu <u9012063@...il.com> To: Jiri Benc <jbenc@...hat.com> Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>, pravin shelar <pshelar@....org> Subject: Re: [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II support Hi Jiri, On Thu, Jan 18, 2018 at 2:13 AM, Jiri Benc <jbenc@...hat.com> wrote: > Looks much better. > > On Wed, 17 Jan 2018 09:32:51 -0800, William Tu wrote: >> + OVS_ERSPAN_OPT_IDX, /* be32 index */ > > Why don't you convert this to u32 while passing to/from user space? > >> + [OVS_ERSPAN_OPT_IDX] = { .len = sizeof(u32) }, > > sizeof(__be32) but see above. > > Thanks, > > Jiri Thanks. Your suggestion makes sense. In the beginning I just want to avoid another ntoh, hton conversion. Since the ERSPAN iproute2 also assume u32 to/from userspace, I will change it here to use u32. William
Powered by blists - more mailing lists