netdev - Re: [net] fm10k: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 16:19:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     arnd@...db.de, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net] fm10k: mark PM functions as __maybe_unused

From: David Miller <davem@...emloft.net>
Date: Thu, 18 Jan 2018 15:52:38 -0500 (EST)

> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Wed, 17 Jan 2018 07:57:32 -0800
> 
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> A cleanup of the PM code left an incorrect #ifdef in place, leading
>> to a harmless build warning:
>> 
>> drivers/net/ethernet/intel/fm10k/fm10k_pci.c:2502:12: error: 'fm10k_suspend' defined but not used [-Werror=unused-function]
>> drivers/net/ethernet/intel/fm10k/fm10k_pci.c:2475:12: error: 'fm10k_resume' defined but not used [-Werror=unused-function]
>> 
>> It's easier to use __maybe_unused attributes here, since you
>> can't pick the wrong one.
>> 
>> Fixes: 8249c47c6ba4 ("fm10k: use generic PM hooks instead of legacy PCIe power hooks")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Acked-by: Jacob Keller <jacob.e.keller@...el.com>
>> Tested-by: Krishneil Singh <krishneil.k.singh@...el.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Applied, thanks Arnd.

Of course, thank you to Jeff as well :-)