netdev - Re: [PATCH net-next] l2tp: remove switch block in l2tp_nl_cmd_session

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Jan 2018 15:10:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev@...r.kernel.org, jchapman@...alix.com, g.nault@...halink.fr
Subject: Re: [PATCH net-next] l2tp: remove switch block in
 l2tp_nl_cmd_session_create()

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Wed, 17 Jan 2018 11:41:20 +0100

> Remove the switch block in l2tp_nl_cmd_session_create() that
> checks pseudowire-specific parameters since just L2TP_PWTYPE_ETH and
> L2TP_PWTYPE_PPP are currently supported and no actual checks are
> performed. Moreover the L2TP_PWTYPE_IP/default case presents a harmless
> issue in error handling (break instead of goto out_tunnel)
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>

Applied, thanks.