netdev - Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 18:55:18 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bridge: return boolean instead of integer in
 br_multicast_is_router


Quoting Stephen Hemminger <stephen@...workplumber.org>:

> On Thu, 18 Jan 2018 17:37:45 -0600
> "Gustavo A. R. Silva" <garsilva@...eddedor.com> wrote:
>
>> Return statements in functions returning bool should use
>> true/false instead of 1/0.
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>
> LGTM
>
> Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is  
> not enabled")
> Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>

Thanks Stephen.
--
Gustavo