netdev - Re: [PATCH net V2] net/mlx5e: Fix fixpoint divide exception in mlx5e_am_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 Jan 2018 18:07:13 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     netdev@...r.kernel.org, talatb@...lanox.com
Subject: Re: [PATCH net V2] net/mlx5e: Fix fixpoint divide exception in
 mlx5e_am_stats_compare

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Sun, 21 Jan 2018 05:30:42 +0200

> From: Talat Batheesh <talatb@...lanox.com>
> 
> Helmut reported a bug about division by zero while
> running traffic and doing physical cable pull test.
> 
> When the cable unplugged the ppms become zero, so when
> dividing the current ppms by the previous ppms in the
> next dim iteration there is division by zero.
> 
> This patch prevent this division for both ppms and epms.
> 
> Fixes: c3164d2fc48f ("net/mlx5e: Added BW check for DIM decision mechanism")
> Reported-by: Helmut Grauer <helmut.grauer@...ibm.com>
> Signed-off-by: Talat Batheesh <talatb@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> ---
> v2:
>     - Fix spelling in commit message.
> 
> This patch is the equivalent of:
> ("net/dim: Fix fixpoint divide exception in net_dim_stats_compare")
> which was already submitted to net-next. Since mlx5 irq moderation code
> got moved in net-next, this patch should only go to net and skip net-next.
> 
> for -stable: 4.12.y and later.

Applied and queue up for -stable, thank you.