netdev - Re: [Patch net-next] tun: avoid calling xdp_rxq_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Jan 2018 16:55:53 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, jasowang@...hat.com
Subject: Re: [Patch net-next] tun: avoid calling xdp_rxq_info_unreg() twice

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Mon, 22 Jan 2018 13:49:27 -0800

> Similarly to tx ring, xdp_rxq_info is only registered
> when !tfile->detached, so we need to avoid calling
> xdp_rxq_info_unreg() twice too. The helper tun_cleanup_tx_ring()
> already checks for this properly, so it is correct to put
> xdp_rxq_info_unreg() just inside there.
> 
> Reported-by: syzbot+1c788d7ce0f0888f1d7f@...kaller.appspotmail.com
> Fixes: 8565d26bcb2f ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")
> Cc: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

I knew it!  :-)

Thanks for fixing this so fast Cong.

Applied.