netdev - Re: [PATCH] net: make sure skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Jan 2018 11:25:47 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     nicolas.dichtel@...nd.com
Cc:     code@...pl.cz, lucien.xin@...il.com, netdev@...r.kernel.org,
        jbenc@...hat.com, pablo@...filter.org, edumazet@...gle.com,
        dsahern@...il.com, tgraf@...g.ch
Subject: Re: [PATCH] net: make sure skb_dst is valid before using

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Wed, 24 Jan 2018 16:37:56 +0100

> I would prefer a patch that test if the handler is available. It
> would prevent to have this bug again in the future. But I don't have
> a strong opinion about this.

Yes that's probably better, making all calls to these dst_ops that
are troublesome for metadata-dsts go through a helper function.

Can someone code that up quickly?

Thanks.