netdev - Re: [PATCH iproute2] tc: fix second printing of requeues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 Jan 2018 16:08:33 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     dsahern@...il.com, jiri@...nulli.us, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH iproute2] tc: fix second printing of requeues

On Sat, 27 Jan 2018 01:19:04 -0800
Jakub Kicinski <jakub.kicinski@...ronome.com> wrote:

> Non-JSON tc qdisc output used to print the "requeues" statistic
> twice.  Commit 4fcec7f3665b ("tc: jsonify stats2") tried to preserve
> this behaviour for both standard output and JSON, but used the wrong
> statistic (q.qlen).  Also duplicating keys in JSON is not allowed,
> so the second occurrence should be completely skipped with JSON.
> 
> Fixes: 4fcec7f3665b ("tc: jsonify stats2")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Also applied this fix