lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 31 Jan 2018 03:34:53 -0800
From:   Joe Perches <joe@...ches.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:     Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 2/7] fm10k: cleanup unnecessary parenthesis in
 fm10k_iov.c

On Wed, 2018-01-24 at 14:45 -0800, Jeff Kirsher wrote:
> This fixes a few warnings found by checkpatch.pl --strict
[]
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c
[]
> @@ -353,7 +353,7 @@ int fm10k_iov_resume(struct pci_dev *pdev)
>  		struct fm10k_vf_info *vf_info = &iov_data->vf_info[i];
>  
>  		/* allocate all but the last GLORT to the VFs */
> -		if (i == ((~hw->mac.dglort_map) >> FM10K_DGLORTMAP_MASK_SHIFT))
> +		if (i == (~hw->mac.dglort_map >> FM10K_DGLORTMAP_MASK_SHIFT))

Strictly, only the if needs parentheses here, but I
think it reads better before this change.

> @@ -511,7 +511,7 @@ int fm10k_iov_configure(struct pci_dev *pdev, int num_vfs)
>  		return err;
>  
>  	/* allocate VFs if not already allocated */
> -	if (num_vfs && (num_vfs != current_vfs)) {
> +	if (num_vfs && num_vfs != current_vfs) {


Powered by blists - more mailing lists