netdev - Re: [Intel-wired-lan] [PATCH] ixgbevf: remove redundant initialization of variable 'dma'.

Open Source and information security mailing list archives

Date:   Thu, 1 Feb 2018 12:29:24 -0800
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        Netdev <netdev@...r.kernel.org>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] ixgbevf: remove redundant
 initialization of variable 'dma'.

On Thu, Feb 1, 2018 at 10:35 AM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Variable dma is initialized with a value that is never read, later
> on it is re-assigned a new value, hence the initialization is redundant
> and can be removed.
>
> Cleans up clang warning:
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:584:13: warning: Value
> stored to 'dma' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>

> ---
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index 9b3d43d28106..be50facec93f 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -558,7 +558,7 @@ static bool ixgbevf_alloc_mapped_page(struct ixgbevf_ring *rx_ring,
>                                       struct ixgbevf_rx_buffer *bi)
>  {
>         struct page *page = bi->page;
> -       dma_addr_t dma = bi->dma;
> +       dma_addr_t dma;
>
>         /* since we are recycling buffers we should seldom need to alloc */
>         if (likely(page))
> --
> 2.15.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives