netdev - Re: [PATCH bpf-next] netdevsim: fix overflow on the error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Feb 2018 10:46:59 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     daniel@...earbox.net, alexei.starovoitov@...il.com,
        dan.carpenter@...cle.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next] netdevsim: fix overflow on the error path

On Fri, Jan 26, 2018 at 07:50:00PM -0800, Jakub Kicinski wrote:
> Undo loop condition on the error path would cause the i counter
> to go below zero, if allocation failure happened with the first
> (i.e. 0th) element of the array.
> 
> Fixes: 395cacb5f1a0 ("netdevsim: bpf: support fake map offload")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>