netdev - Re: [patch net] rocker: fix possible null pointer dereference in rocker_router_fib_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 01 Feb 2018 09:52:00 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, mlxsw@...lanox.com
Subject: Re: [patch net] rocker: fix possible null pointer dereference in
 rocker_router_fib_event_work

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu,  1 Feb 2018 12:21:15 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Currently, rocker user may experience following null pointer
> derefence bug:
> 
> [    3.062141] BUG: unable to handle kernel NULL pointer dereference at 00000000000000d0
> [    3.065163] IP: rocker_router_fib_event_work+0x36/0x110 [rocker]
> 
> The problem is uninitialized rocker->wops pointer that is initialized
> only with the first initialized port. So move the port initialization
> before registering the fib events.
> 
> Fixes: 936bd486564a ("rocker: use FIB notifications instead of switchdev calls")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for -stable, thanks Jiri.