netdev - Re: [PATCH net] Revert "defer call to mem_cgroup_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 02 Feb 2018 11:34:56 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Roman Gushchin <guro@...com>
Cc:     Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@...com,
        "David S . Miller" <davem@...emloft.net>,
        Johannes Weiner <hannes@...xchg.org>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH net] Revert "defer call to mem_cgroup_sk_alloc()"

On Fri, 2018-02-02 at 19:04 +0000, Roman Gushchin wrote:
> On Fri, Feb 02, 2018 at 10:39:04AM -0800, Eric Dumazet wrote:
> > On Fri, 2018-02-02 at 18:06 +0000, Roman Gushchin wrote:
> > > 
> > > Idk, how even we can hit it? And if so, what scary will happen?
> > > 
> > > If you prefer to have it there, I definitely can return it,
> > > but I see no profit so far.
> > 
> > I was simply curious this was not mentioned in the changelog.
> > 
> > A revert is normally a true revert, modulo the changes needed by
> > conflicts and possible changes.
> > 
> > I personally do not care of this BUG_ON(), I had not put it in the
> > first place.
> 
> Technically it's not a true revert, but you're totally right.
> Let me add a note to the commit description.
> 
> Are you ok with the rest?

Sure !

Thanks.