netdev - Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Feb 2018 12:34:25 -0200
From:   Desnes Augusto Nunes do Rosário 
        <desnesn@...ux.vnet.ibm.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        tlfalcon@...ux.vnet.ibm.com, jallen@...ux.vnet.ibm.com,
        nfont@...ux.vnet.ibm.com
Subject: Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level
 has been provided by the VIOS server

Hello David,

Thank you for your review and the heads up about protocol.

On 02/01/2018 05:59 PM, David Miller wrote:
> From: Desnes Augusto Nunes do Rosario <desnesn@...ux.vnet.ibm.com>
> Date: Thu,  1 Feb 2018 16:04:30 -0200
> 
>> Older versions of VIOS servers do not send the firmware level in the VPD
>> buffer for the ibmvnic driver. Thus, not only the current message is mis-
>> leading but the firmware version in the ethtool will be NULL. Therefore,
>> this patch fixes the firmware string and its warning.
>>
>> Fixes: 4e6759be28e4 ("ibmvnic: Feature implementation of VPD for the ibmvnic driver")
>>
>> Signed-off-by: Desnes A. Nunes do Rosario <desnesn@...ux.vnet.ibm.com>
> 
> Applied.
> 
> Please do not put empty lines between Fixes: and Signed-off-by: and other
> tags, all tags are equal and are placed together in an uninterrupted
> sequences of consequetive lines.
> 
> Thank you.
> 

-- 
Desnes Augusto Nunes do Rosário
------------------------------------------

Linux Developer - IBM / Brazil
M.Sc. in Electrical and Computer Engineering - UFRN