lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Feb 2018 11:50:18 +0100 From: Dmitry Vyukov <dvyukov@...gle.com> To: syzbot <syzbot+@...kaller.appspotmail.com> Cc: Paolo Abeni <pabeni@...hat.com>, coreteam@...filter.org, David Miller <davem@...emloft.net>, Florian Westphal <fw@...len.de>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org, Pablo Neira Ayuso <pablo@...filter.org>, syzkaller-bugs@...glegroups.com, Cong Wang <xiyou.wangcong@...il.com>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org> Subject: Re: WARNING: proc registration bug in clusterip_tg_check You dropped syzbot from CC ;) Add syzbot+03218bcdba6aa76441a3@...kaller.appspotmail.com to To or CC. On Wed, Feb 7, 2018 at 11:42 AM, syzbot <syzbot+@...kaller.appspotmail.com> wrote: >> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git >> master > > > Can't find the corresponding bug. > > > >> I can't reproduce the issue locally, so asking the syzbot to test the >> tentive fix for me (and hoping I did not mess with the tag/format) > > >> --- >> net/ipv4/netfilter/ipt_CLUSTERIP.c | 30 +++++++++++++++--------------- >> 1 file changed, 15 insertions(+), 15 deletions(-) > > >> diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c >> b/net/ipv4/netfilter/ipt_CLUSTERIP.c >> index 3a84a60f6b39..db103cd971a9 100644 >> --- a/net/ipv4/netfilter/ipt_CLUSTERIP.c >> +++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c >> @@ -230,17 +230,6 @@ clusterip_config_init(struct net *net, const struct >> ipt_clusterip_tgt_info *i, >> refcount_set(&c->refcount, 1); >> refcount_set(&c->entries, 1); > > >> - spin_lock_bh(&cn->lock); >> - if (__clusterip_config_find(net, ip)) { >> - spin_unlock_bh(&cn->lock); >> - kfree(c); >> - >> - return ERR_PTR(-EBUSY); >> - } >> - >> - list_add_rcu(&c->list, &cn->configs); >> - spin_unlock_bh(&cn->lock); >> - >> #ifdef CONFIG_PROC_FS >> { >> char buffer[16]; >> @@ -257,20 +246,31 @@ clusterip_config_init(struct net *net, const struct >> ipt_clusterip_tgt_info *i, >> } >> #endif > > >> + spin_lock_bh(&cn->lock); >> + if (__clusterip_config_find(net, ip)) { >> + spin_unlock_bh(&cn->lock); >> + err = -EBUSY; >> + goto err_remove_pte: >> + } >> + >> + list_add_rcu(&c->list, &cn->configs); >> + spin_unlock_bh(&cn->lock); >> + >> c->notifier.notifier_call = clusterip_netdev_event; >> err = register_netdevice_notifier(&c->notifier); >> if (!err) >> return c; > > >> + spin_lock_bh(&cn->lock); >> + list_del_rcu(&c->list); >> + spin_unlock_bh(&cn->lock); >> + >> +err_remove_pte: >> #ifdef CONFIG_PROC_FS >> proc_remove(c->pde); >> err: >> #endif >> - spin_lock_bh(&cn->lock); >> - list_del_rcu(&c->list); >> - spin_unlock_bh(&cn->lock); >> kfree(c); >> - >> return ERR_PTR(err); >> } > > >> -- >> 2.14.3 > > >> -- >> You received this message because you are subscribed to the Google Groups >> "syzkaller-bugs" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to syzkaller-bugs+unsubscribe@...glegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/syzkaller-bugs/945c8517a87c671825b61223088064ea2ad0a8cb.1517999262.git.pabeni%40redhat.com. >> For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "syzkaller-bugs" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to syzkaller-bugs+unsubscribe@...glegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/syzkaller-bugs/001a114372a68e749405649cf352%40google.com. > > For more options, visit https://groups.google.com/d/optout.
Powered by blists - more mailing lists