netdev - Re: [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Feb 2018 13:33:41 -0600
From:   Nathan Fontenot <nfont@...ux.vnet.ibm.com>
To:     Jakub Kicinski <kubakici@...pl>
Cc:     netdev@...r.kernel.org, jallen@...ux.vnet.ibm.com,
        tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit

On 02/09/2018 01:32 PM, Jakub Kicinski wrote:
> On Fri, 09 Feb 2018 13:09:34 -0600, Nathan Fontenot wrote:
>> From: John Allen (jallen@...ux.vnet.ibm.com>
> 
> Nit: s/(/</
> 
>> Having these checks in ibmvnic_xmit causes problems with VLAN
>> tagging and balance-alb/tlb bonding modes. The restriction they
>> imposed can be removed.
>>
>> Signed-off-by: Nathan Fontenot <nfont@...ux.vnet.ibm.com>
> 
> Patch does not have author's SoB line, the kernel bots will complain
> about this, so please add it if it's not a problem.
> 

Oops. Thanks for pointing this out, I'll re-send.

-Nathan