netdev - Re: [PATCH net-next v3 00/16] l2tp: fix API races discovered by syzbot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Feb 2018 14:00:12 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jchapman@...alix.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 00/16] l2tp: fix API races discovered by
 syzbot

From: James Chapman <jchapman@...alix.com>
Date: Mon, 12 Feb 2018 17:33:23 +0000

> This patch series addresses several races with L2TP APIs discovered by
> syzbot. While working on this, it became clear that the L2TP code
> needed some work to address object lifetime issues. There are no
> functional changes.
> 
> The set of patches 1-13 in combination fix the following syzbot reports.
> 
> 9df43faf0 KASAN: use-after-free Read in pppol2tp_connect
> 6e6a5ec8d general protection fault in pppol2tp_connect
> 347bd5acd KASAN: use-after-free Read in inet_shutdown
> 19c09769f WARNING in debug_print_object

Some symbol export issues:

ERROR: "l2tp_tunnel_free" [net/l2tp/l2tp_ppp.ko] undefined!
ERROR: "l2tp_tunnel_free" [net/l2tp/l2tp_netlink.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1

Also, this series is also a hodge-podge of bug fixes that really belong
in 'net' alongside cleanups and refactoring that belong in 'net-next'.

Can you please pull out the genuine bug fixes into a smaller series
targetting 'net' and then after you fix the symbol export issues
we can build on top of that in net-next with the cleanups and
refactoring.

Thank you.