netdev - Re: [PATCH net v2] tipc: fix missing RTNL lock protection during setting link properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Feb 2018 10:08:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ktkhai@...tuozzo.com
Cc:     ying.xue@...driver.com, jon.maloy@...csson.com,
        netdev@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net v2] tipc: fix missing RTNL lock protection during
 setting link properties

From: Kirill Tkhai <ktkhai@...tuozzo.com>
Date: Mon, 12 Feb 2018 13:10:34 +0300

> This err branch looks excess. It was before your patch, but in case of you change this place,
> can't we stop having it? it looks like we can simply do the below here:
> 
> 	err = tipc_enable_bearer(net, bearer, domain, prio, attrs);
> 	return err;

Or even better, straight:

	return tipc_enable_bearer(net, bearer, domain, prio, attrs);