netdev - Re: [PATCH V2 net-next] rds: do not call ->conn_alloc with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Feb 2018 15:41:11 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sowmini.varadhan@...cle.com
Cc:     netdev@...r.kernel.org, santosh.shilimkar@...cle.com
Subject: Re: [PATCH V2 net-next] rds: do not call ->conn_alloc with
 GFP_KERNEL

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Tue, 13 Feb 2018 09:05:44 -0800

> Commit ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize
> netns/module teardown and rds connection/workq management")
> adds an rcu read critical section to __rd_conn_create. The
> memory allocations in that critcal section need to use
> GFP_ATOMIC to avoid sleeping.
> 
> This patch was verified with syzkaller reproducer.
> 
> Fixes: ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize
>        netns/module teardown and rds connection/workq management")
> Reported-by: syzbot+a0564419941aaae3fe3c@...kaller.appspotmail.com
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> ---
> v2: do not over-engineer. Keep the gfp arg to ->conn_alloc simple.

Already applied to 'net', no need to send this again.