netdev - Re: [PATCH net v4 0/7] tipc: Fix missing RTNL lock protection during setting link properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Feb 2018 14:46:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ying.xue@...driver.com
Cc:     ktkhai@...tuozzo.com, jon.maloy@...csson.com,
        netdev@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net v4 0/7] tipc: Fix missing RTNL lock protection
 during setting link properties

From: Ying Xue <ying.xue@...driver.com>
Date: Wed, 14 Feb 2018 13:37:57 +0800

> At present it's unsafe to configure link properties through netlink
> as the entire setting process is not under RTNL lock protection. Now
> TIPC supports two different sets of netlink APIs at the same time, and
> they share the same set of backend functions to configure bearer,
> media and net properties. In order to solve the missing RTNL issue,
> we have to make the whole __tipc_nl_compat_doit() protected by RTNL,
> which means any function called within it cannot take RTNL any more.
> So in the series we first introduce the following new functions which
> doesn't hold RTNl lock:
> 
>  - __tipc_nl_bearer_disable()
>  - __tipc_nl_bearer_enable()
>  - __tipc_nl_bearer_set()
>  - __tipc_nl_media_set()
>  - __tipc_nl_net_set()
> 
> Meanwhile, __tipc_nl_compat_doit() has been reconstructed to minimize
> the time of holding RTNL lock.
> 
> Changes in v4:
>  - Per suggestion of Kirill Tkhai, divided original big one patch into
>    seven small ones so that they can be easily reviewed.
> 
> Changes in v3: 
>  - Optimized return method of __tipc_nl_bearer_enable() regarding
>    the comments from David M and Kirill Tkhai
>  - Moved the allocations of memory in __tipc_nl_compat_doit() out
>    of RTNL lock to minimize the time of holding RTNL lock according
>    to the suggestion of Kirill Tkhai.
> 
> Changes in v2:
>  - The whole operation of setting bearer/media properties has been
>    protected under RTNL, as per feedback from David M.

Series applied, thank you.