lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Feb 2018 08:31:50 -0800 From: Joe Perches <joe@...ches.com> To: Andy Shevchenko <andy.shevchenko@...il.com>, Colin Ian King <colin.king@...onical.com> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>, intel-wired-lan@...ts.osuosl.org, netdev <netdev@...r.kernel.org>, kernel-janitors@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks On Sun, 2018-02-18 at 16:58 +0200, Andy Shevchenko wrote: > On Fri, Feb 16, 2018 at 6:53 PM, Colin Ian King > <colin.king@...onical.com> wrote: > > On 16/02/18 16:51, Andy Shevchenko wrote: > > > On Thu, Feb 15, 2018 at 9:42 PM, Colin King <colin.king@...onical.com> wrote: > > > > + filter->f.mask.tcp_spec.dst_ip[i] |= > > > > cpu_to_be32(0xffffffff); > > > > > > Can it be one line then? > > > > I re-adjusted the text because checkpatch was complaining. > > > > > > > + filter->f.mask.tcp_spec.src_ip[i] |= > > > > cpu_to_be32(0xffffffff); > > For the rest OK, but for the above two how much over 80 it went if > would be one line? > If it 2-3 characters, consider to make it one line. It would increase > readability. Another possibility would be to use temporaries for filter->f.mask.tcp_spec and filter->f.data.tcp_spec as both are used ~10 times in the function
Powered by blists - more mailing lists