netdev - Re: [PATCH net-next3/5] ibmvnic: Free and re-allocate scrqs when tx/rx scrqs change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Feb 2018 13:27:57 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        jallen@...ux.vnet.ibm.com, tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next3/5] ibmvnic: Free and re-allocate scrqs when
 tx/rx scrqs change

Hi Nathan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.16-rc2 next-20180216]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nathan-Fontenot/ibmvnic-Free-and-re-allocate-scrqs-when-tx-rx-scrqs-change/20180218-203503
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   drivers/net//ethernet/ibm/ibmvnic.c: In function 'release_sub_crqs':
>> drivers/net//ethernet/ibm/ibmvnic.c:2340:28: error: 'struct ibmvnic_adapter' has no member named 'num_active_tx_scrqs'; did you mean 'num_active_tx_pools'?
      for (i = 0; i < adapter->num_active_tx_scrqs; i++) {
                               ^~~~~~~~~~~~~~~~~~~
                               num_active_tx_pools
>> drivers/net//ethernet/ibm/ibmvnic.c:2362:28: error: 'struct ibmvnic_adapter' has no member named 'num_active_rx_scrqs'; did you mean 'num_active_rx_pools'?
      for (i = 0; i < adapter->num_active_rx_scrqs; i++) {
                               ^~~~~~~~~~~~~~~~~~~
                               num_active_rx_pools

vim +2340 drivers/net//ethernet/ibm/ibmvnic.c

  2334	
  2335	static void release_sub_crqs(struct ibmvnic_adapter *adapter, int do_h_free)
  2336	{
  2337		int i;
  2338	
  2339		if (adapter->tx_scrq) {
> 2340			for (i = 0; i < adapter->num_active_tx_scrqs; i++) {
  2341				if (!adapter->tx_scrq[i])
  2342					continue;
  2343	
  2344				netdev_dbg(adapter->netdev, "Releasing tx_scrq[%d]\n",
  2345					   i);
  2346				if (adapter->tx_scrq[i]->irq) {
  2347					free_irq(adapter->tx_scrq[i]->irq,
  2348						 adapter->tx_scrq[i]);
  2349					irq_dispose_mapping(adapter->tx_scrq[i]->irq);
  2350					adapter->tx_scrq[i]->irq = 0;
  2351				}
  2352	
  2353				release_sub_crq_queue(adapter, adapter->tx_scrq[i],
  2354						      do_h_free);
  2355			}
  2356	
  2357			kfree(adapter->tx_scrq);
  2358			adapter->tx_scrq = NULL;
  2359		}
  2360	
  2361		if (adapter->rx_scrq) {
> 2362			for (i = 0; i < adapter->num_active_rx_scrqs; i++) {
  2363				if (!adapter->rx_scrq[i])
  2364					continue;
  2365	
  2366				netdev_dbg(adapter->netdev, "Releasing rx_scrq[%d]\n",
  2367					   i);
  2368				if (adapter->rx_scrq[i]->irq) {
  2369					free_irq(adapter->rx_scrq[i]->irq,
  2370						 adapter->rx_scrq[i]);
  2371					irq_dispose_mapping(adapter->rx_scrq[i]->irq);
  2372					adapter->rx_scrq[i]->irq = 0;
  2373				}
  2374	
  2375				release_sub_crq_queue(adapter, adapter->rx_scrq[i],
  2376						      do_h_free);
  2377			}
  2378	
  2379			kfree(adapter->rx_scrq);
  2380			adapter->rx_scrq = NULL;
  2381		}
  2382	}
  2383	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (56628 bytes)