lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Feb 2018 12:48:21 +0100 From: Jon Maloy <jon.maloy@...csson.com> To: <davem@...emloft.net>, <netdev@...r.kernel.org> CC: <mohan.krishna.ghanta.krishnamurthy@...csson.com>, <tung.q.nguyen@...tech.com.au>, <hoang.h.le@...tech.com.au>, <jon.maloy@...csson.com>, <canh.d.luu@...tech.com.au>, <ying.xue@...driver.com>, <tipc-discussion@...ts.sourceforge.net> Subject: [net-next 1/1] tipc: fix bug on error path in tipc_topsrv_kern_subscr() In commit cc1ea9ffadf7 ("tipc: eliminate struct tipc_subscriber") we re-introduced an old bug on the error path in the function tipc_topsrv_kern_subscr(). We now re-introduce the correction too. Reported-by: syzbot+f62e0f2a0ef578703946@...kaller.appspotmail.com Signed-off-by: Jon Maloy <jon.maloy@...csson.com> --- net/tipc/topsrv.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c index 02013e0..25925be 100644 --- a/net/tipc/topsrv.c +++ b/net/tipc/topsrv.c @@ -580,9 +580,10 @@ bool tipc_topsrv_kern_subscr(struct net *net, u32 port, u32 type, u32 lower, *conid = con->conid; con->sock = NULL; rc = tipc_conn_rcv_sub(tipc_topsrv(net), con, &sub); - if (rc < 0) - tipc_conn_close(con); - return !rc; + if (rc >= 0) + return true; + conn_put(con); + return false; } void tipc_topsrv_kern_unsubscr(struct net *net, int conid) -- 2.1.4
Powered by blists - more mailing lists