lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Feb 2018 11:49:40 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Roman Kapl <code@...pl.cz> Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Benc <jbenc@...hat.com> Subject: Re: [PATCH v2] sched: report if filter is too large to dump Mon, Feb 19, 2018 at 09:32:51PM CET, code@...pl.cz wrote: >So far, if the filter was too large to fit in the allocated skb, the >kernel did not return any error and stopped dumping. Modify the dumper >so that it returns -EMSGSIZE when a filter fails to dump and it is the >first filter in the skb. If we are not first, we will get a next chance >with more room. > >I understand this is pretty near to being an API change, but the >original design (silent truncation) can be considered a bug. > >Note: The error case can happen pretty easily if you create a filter >with 32 actions and have 4kb pages. Also recent versions of iproute try >to be clever with their buffer allocation size, which in turn leads to > >Signed-off-by: Roman Kapl <code@...pl.cz> Acked-by: Jiri Pirko <jiri@...lanox.com>
Powered by blists - more mailing lists