netdev - Re: [PATCH iproute2-next] color: disable color when json output is requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Feb 2018 16:04:55 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vincent Bernat <vincent@...nat.im>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] color: disable color when json output is
 requested

On Wed, 21 Feb 2018 00:28:04 +0100
Vincent Bernat <vincent@...nat.im> wrote:

> Instead of declaring -color and -json exclusive, ignore -color when
> -json is provided. The rationale is to allow to put -color in an alias
> for ip while still being able to use -json. -color is merely a
> presentation suggestion and we can assume there is nothing to color in
> the JSON output.
> 
> Signed-off-by: Vincent Bernat <vincent@...nat.im>

Looks fine to me, this could even go into master.
Need to update man page and make sure behavior is consistent
across ip, tc, and bridge commands.