netdev - Re: [PATCH 1/3] net: Kill net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Feb 2018 13:16:05 +0300
From:   Kirill Tkhai <ktkhai@...tuozzo.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     davem@...emloft.net, nicolas.dichtel@...nd.com,
        vyasevic@...hat.com, paulmck@...ux.vnet.ibm.com,
        vyasevich@...il.com, mark.rutland@....com,
        gregkh@...uxfoundation.org, leonro@...lanox.com,
        avagin@...tuozzo.com, fw@...len.de, roman.kapl@...go.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] net: Kill net_mutex

Hi, Stephen,

On 21.02.2018 02:18, Stephen Hemminger wrote:
> On Mon, 19 Feb 2018 12:58:38 +0300
> Kirill Tkhai <ktkhai@...tuozzo.com> wrote:
> 
>> +	struct list_head	exit_list;	/* To linked to call pernet exit
>> +						 * methods on dead net (net_sem
>> +						 * read locked), or to unregister
>> +						 * pernet ops (net_sem wr locked).
>> +						 */
> 
> Sorry, that comment is completely unparseable.
> Either you know what it does, and therefore comment is unnecessary
> Or change comment to a valid explanation of the semantics of the list.
> 
> Maybe comments about locking model are best left to where
> it is used in the code.

Let's improve it :) It's used to call pernet exit methods, and net ns logic
guarantees, we never call exit methods for the same net in parallel. How
about writing this directly without mention of net_sem? Something like this:

/* To link net to call pernet exit methods */

Or maybe you have better variant?

Thanks,
Kirill