lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Feb 2018 12:43:30 -0500 (EST) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: netdev@...r.kernel.org, john.fastabend@...il.com, xiyou.wangcong@...il.com, jhs@...atatu.com, jiri@...nulli.us Subject: Re: [PATCH v2 net] net_sched: gen_estimator: fix broken estimators based on percpu stats From: Eric Dumazet <eric.dumazet@...il.com> Date: Thu, 22 Feb 2018 19:45:27 -0800 > From: Eric Dumazet <edumazet@...gle.com> > > pfifo_fast got percpu stats lately, uncovering a bug I introduced last > year in linux-4.10. > > I missed the fact that we have to clear our temporary storage > before calling __gnet_stats_copy_basic() in the case of percpu stats. > > Without this fix, rate estimators (tc qd replace dev xxx root est 1sec > 4sec pfifo_fast) are utterly broken. > > Fixes: 1c0d32fde5bd ("net_sched: gen_estimator: complete rewrite of rate estimators") > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > --- > v2: Perform the zeroing in est_fetch_counters() instead of caller(s) Applied and queued up for -stable.
Powered by blists - more mailing lists