netdev - Re: [PATCH RFC net-next 01/20] net: Move fib_convert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Feb 2018 14:05:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        roopa@...ulusnetworks.com, eric.dumazet@...il.com,
        weiwan@...gle.com, kafai@...com, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH RFC net-next 01/20] net: Move fib_convert_metrics to
 dst core

From: David Ahern <dsahern@...il.com>
Date: Sun, 25 Feb 2018 11:47:11 -0800

> diff --git a/net/core/dst.c b/net/core/dst.c
> index 007aa0b08291..5f70bc832bec 100644
> --- a/net/core/dst.c
> +++ b/net/core/dst.c
...
> +			val = tcp_ca_get_key_by_name(net, tmp, &ecn_ca);
> +			if (val == TCP_CA_UNSPEC)
> +				return -EINVAL;

This makes the networking core depend upon CONFIG_INET.

You will have to untangle this somehow before your final submission.
Probably with an inline helper in the non-INET case that always
returns TCP_CA_UNSPEC.