netdev - Re: [PATCH bpf-next 1/2] bpf: extend stackmap to save binary_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Feb 2018 11:42:57 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     songliubraving@...com
Cc:     netdev@...r.kernel.org, ast@...nel.org, peterz@...radead.org,
        daniel@...earbox.net, kernel-team@...com, hannes@...xchg.org
Subject: Re: [PATCH bpf-next 1/2] bpf: extend stackmap to save
 binary_build_id+offset instead of address

From: Song Liu <songliubraving@...com>
Date: Mon, 26 Feb 2018 09:49:22 -0800

> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
> index b0ecf43..e6a48ca 100644
> --- a/kernel/bpf/stackmap.c
> +++ b/kernel/bpf/stackmap.c
> @@ -9,16 +9,18 @@
>  #include <linux/filter.h>
>  #include <linux/stacktrace.h>
>  #include <linux/perf_event.h>
> +#include <uapi/linux/elf.h>
>  #include "percpu_freelist.h"

Hmmm, why do you explicitly need to include a uapi path?  linux/elf.h
should resolve naturally without such an explicit uapi path.