netdev - Re: [net 1/1] tipc: correct initial value for group congestion flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Feb 2018 11:47:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net 1/1] tipc: correct initial value for group congestion flag

From: Jon Maloy <jon.maloy@...csson.com>
Date: Mon, 26 Feb 2018 20:14:04 +0100

> In commit 60c253069632 ("tipc: fix race between poll() and
> setsockopt()") we introduced a pointer from struct tipc_group to the
> 'group_is_connected' flag in struct tipc_sock, so that this field can
> be checked without dereferencing the group pointer of the latter struct.
> 
> The initial value for this flag is correctly set to 'false' when a
> group is created, but we miss the case when no group is created at
> all, in which case the initial value should be 'true'. This has the
> effect that SOCK_RDM/DGRAM sockets sending datagrams never receive
> POLLOUT if they request so.
> 
> This commit corrects this bug.
> 
> Reported-by: Hoang Le <hoang.h.le@...tek.com.au>
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks.

Please provide a proper Fixes: tag next time.  I added it for you
in this case.